Ensure game stops after timeout #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses an issue where games were not being properly terminated when the time limit was reached. The agent was previously responsible for calling endGame() after announcing time expiration, but this proved unreliable. The solution moves the responsibility for stopping the game to the backend's timeout handler.
Changes:
- Backend now directly calls
stopGame()after announcing time expiration instead of relying on the agent - Agent's timeout message simplified to remove instruction to call
endGame() - Session state initialization improved by explicitly setting
endingflag tofalseon open
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
deep-sea-stories/packages/backend/src/game/room.ts |
Added explicit stopGame() call in timeout handler to ensure game termination |
deep-sea-stories/packages/backend/src/agent/gemini/session.ts |
Removed agent responsibility for calling endGame() and added state flag initialization |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
czerwiukk
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs showed that sometimes the agent doesn't close the game when time runs out, so we now do it instead